Flag status #26

ABTastyAdel · 2023-08-22T15:10:23Z

No description provided.

codecov · 2023-08-22T15:16:23Z

Codecov Report

Merging #26 (ae3150d) into master (d73771e) will increase coverage by 0.02%.
The diff coverage is 88.23%.

❗ Current head ae3150d differs from pull request most recent head 1948c70. Consider uploading reports for the commit 1948c70 to get more accurate results

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   84.37%   84.40%   +0.02%     
==========================================
  Files          61       61              
  Lines        3175     3200      +25     
==========================================
+ Hits         2679     2701      +22     
- Misses        496      499       +3

Files Changed	Coverage Δ
FlagShip/Source/Core/FSFlag.swift	`82.95% <73.33%> (-2.19%)`	⬇️
FlagShip/Source/Logger/FlagshipLogManager.swift	`75.00% <80.00%> (ø)`
FlagShip/Source/Models/FSContext.swift	`88.46% <92.85%> (-0.43%)`	⬇️
...agShip/Source/Core/FSVisitor+Reconcilliation.swift	`100.00% <100.00%> (ø)`
FlagShip/Source/Core/FSVisitor.swift	`92.63% <100.00%> (+0.49%)`	⬆️
FlagShip/Source/Logger/FlagshipConstants.swift	`77.27% <100.00%> (ø)`
FlagShip/Source/Strategy/FSDefaultStrategy.swift	`89.60% <100.00%> (+0.16%)`	⬆️

... and 1 file with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d73771e...1948c70. Read the comment docs.

ABTastyAdel · 2023-08-23T09:18:20Z

FlagShip/Source/Core/FSFlag.swift

+/**
+ * This status represent the flag status depend on visitor actions
+ */
+@objc public enum FlagSynchStatus: Int {


should be internal

ABTastyAdel · 2023-08-23T09:24:54Z

FlagShip/Source/Core/FSFlag.swift

+    case UNAUTHENTICATED
+
+    func warningMessage(_ flagKey: String, _ visitorId: String)->String {
+        var ret = "Visitor `\(visitorId)` has been created without calling `fetchFlags` method afterwards, the value of the flag `\(flagKey)` may be outdated."
