Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text Classifier: Clear embeddings in predict() #149

Closed
tabergma opened this issue Oct 18, 2018 · 0 comments · Fixed by #154
Closed

Text Classifier: Clear embeddings in predict() #149

tabergma opened this issue Oct 18, 2018 · 0 comments · Fixed by #154
Assignees
@tabergma
Labels
enhancement Improving of an existing feature text classification Related to text classifier

Comments

@tabergma
Copy link
Collaborator

In the predict() method of the text classification model the sentence embeddings are not cleared after calculation. This might lead to memory issues.

TODO: Clear embeddings at the end of the predict method.
@tabergma tabergma added enhancement Improving of an existing feature text classification Related to text classifier labels Oct 18, 2018
@tabergma tabergma self-assigned this Oct 18, 2018
tabergma added a commit that referenced this issue Oct 18, 2018
@tabergma
GH-149: Always clear embeddings after predict.
ddafc03
@tabergma tabergma mentioned this issue Oct 18, 2018
Merged
alanakbik pushed a commit that referenced this issue Oct 18, 2018
Merge pull request #154 from zalandoresearch/GH-149-predict-clear-emb…
cb09e3b 
…eddings

GH-149: Always clear embeddings in predict
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tabergma tabergma

Labels
enhancement Improving of an existing feature text classification Related to text classifier
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH-149: Always clear embeddings in predict flairNLP/flair
1 participant
@tabergma