collect formatting tests for flair package #2611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…all_formattings # Conflicts: # flair/embeddings/base.py # flair/training_utils.py
alanakbik
approved these changes
Feb 2, 2022
| @@ -924,7 +924,15 @@ def to_dict(self, tag_type: str = None): | |||
|
|
|||
| return {"text": self.to_original_text(), "all labels": labels} | |||
|
|
|||
| def __getitem__(self, subscript: int) -> Union[Token, Span]: | |||
| @typing.overload | |||
| def __getitem__(self, idx: int) -> Token: | |||
There was a problem hiding this comment.
wow cool construct, I had no idea one could do this!
| @@ -1375,7 +1375,7 @@ def __init__( | |||
|
|
|||
| super(WSD_RAGANATO_ALL, self).__init__( | |||
| data_folder=data_folder, | |||
| columns=columns, | |||
| column_format=columns, | |||
There was a problem hiding this comment.
thanks for spotting and fixing this!
| for predicted_span in predicted_spans: | ||
| span = Span(sentence[predicted_span[0][0] : predicted_span[0][-1] + 1]) | ||
| value = self._remap_label(predicted_span[2]) | ||
| for span_indices, score, label in predicted_spans: |
| @@ -489,10 +489,12 @@ def __init__(self, tokens: List[Token]): | |||
|
|
|||
| @property | |||
| def start_pos(self) -> int: | |||
| assert self.tokens[0].start_position is not None | |||
There was a problem hiding this comment.
out of curiosity: why are these asserts necessary?
|
@helpmefindaname thanks a lot for these many improvements! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have noticed, that my local pytest fails on master due to mypy and flake8 errors but run trough in cicd.
This is an atempt to fix it, so we have a faster feedback loop