Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datasets: add support for version 2.1 of HIPE-2022 #2735

Merged
merged 3 commits into from
May 2, 2022

Conversation

stefan-it
Copy link
Member

@stefan-it stefan-it commented Apr 20, 2022

Hi,

this PR adds support for latest version 2.1 of HIPE-2022 dataset.

It mainly fixes a label correction in the HIPE-2020 French data (training split), and some adjustments in AJMC, see release notes.

Closes #2734

@alanakbik alanakbik requested a review from marcelmmm April 25, 2022 11:20
@alanakbik
Copy link
Collaborator

@marcelmmm can you review and merge?

@marcelmmm
Copy link
Collaborator

marcelmmm commented Apr 27, 2022

sorry @stefan-it I should have done a comment and not directly push to your branch!
However, I got an encoding error when loading the dataset on Windows, the added encoding='utf-8' solved the problem.
Otherwise everything looks fine 👍

Copy link
Collaborator

@marcelmmm marcelmmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@stefan-it
Copy link
Member Author

I think only one additional approval is missing now :)

@alanakbik
Copy link
Collaborator

👍

@alanakbik
Copy link
Collaborator

Approval added but I think the whole zappr thing is broken :/ merging now!

@alanakbik alanakbik merged commit 6ad2598 into master May 2, 2022
@alanakbik alanakbik deleted the hipe-2022-v2.1-update branch May 2, 2022 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for HIPE-2022 v2.1
3 participants