Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH: 3156 caching bugs #3157

Merged
merged 6 commits into from
Mar 22, 2023
Merged

GH: 3156 caching bugs #3157

merged 6 commits into from
Mar 22, 2023

Conversation

alanakbik
Copy link
Collaborator

Draft PR that removes custom equality on DataPoint and increases cache size for context computation. More testing needed if the first is possible without breaking other parts of the code.

@alanakbik
Copy link
Collaborator Author

Update: to fix bug #3157, the following things were changed:

  • the custom equality definition from DataPoint was removed. Two data points are now only the same if they are the same object (previously two data points were the same if they had the same text)
  • the internal handling of how _PartOfSentence objects (like Span) are created is changed to avoid duplicate object creation
  • the caching was removed altogether. I tried different caching sizes and there seems to be no impact on overall speeds.

@alanakbik alanakbik merged commit 524594d into master Mar 22, 2023
@alanakbik alanakbik deleted the GH-3156-caching-bugs branch March 22, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant