Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

character embeddings store their embedding name too #3477

Merged
merged 4 commits into from
Jul 13, 2024
Merged

character embeddings store their embedding name too #3477

merged 4 commits into from
Jul 13, 2024

Conversation

helpmefindaname
Copy link
Collaborator

Fixes #3459

@helpmefindaname helpmefindaname mentioned this pull request Jun 28, 2024
Closed
@alanakbik
Copy link
Collaborator

Can confirm that the issue in #3459 is fixed. Thanks @helpmefindaname!

@alanakbik alanakbik merged commit 472b2c7 into master Jul 13, 2024
1 check passed
@alanakbik alanakbik deleted the store-name-of-charachter-embeddings branch July 13, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanakbik alanakbik alanakbik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Custom trained model not correctly loaded when using FlairEmbeddings
2 participants
@helpmefindaname @alanakbik