-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds DataTriples which act just like DataPairs #3481
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Just some minor mypy problems, concerning implicit optionals. I've added some suggestions as comments to fix the issues.
Co-authored-by: Alan Akbik <alan.akbik@gmail.com>
@janpf thanks a lot for adding this! Will you also add some prepared corpora for the SuperGLEBler datasets in future PRs? |
Thanks for the quick merge, @alanakbik :) Is there an ETA for when the two PRs might land on pypi? :) |
I'm hoping to find enough time to prepare a new release once the semester ends (in two weeks). |
This adds a new DataPoint type consisting of three sentences instead of two. This could/should likely be parameterizable, but this is the easiest way to add this.