bi authentication bug workaround #406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
requested changes
Apr 18, 2024
Yeah, I also tried that, but as it turns out that's a XPath 2.0 feature and lxml only supports XPath 1.0. Trying this results in an Exception raised by lxml |
Good to know! I thought I added it once, but i guess I forgot about the part where an exception was thrown. |
MaxDall
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discovering a bug that BI US sometimes prints incomplete articles, the closest @MaxDall and I got to tracing the issue is that there seems to be some kind of error within the authentication of premium users of the US bi website. The incomplete version is a slight modification of the complete version, where the main content is within another div container, which is blocked from view, when using a browser. What triggers whether or not they ask for a premium login could not be determined. So, the workaround is to expand the selectors to cover both cases.