Fix a bug in bf_search regarding boolean values #422
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a nasty bug in
LD.bf_search
basically rendering the parsing of boolean values unusable. This PR fixes this issue by introducing a new sentinel value and fixing some logic bugs.One problem this could cause is that now the
free_access
attribute finally works as intended and this may cause some trouble since the publishers won't set it honestly.Update: I opened another PR #423 to address this