Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added zdf.de #432

Merged
merged 14 commits into from
May 5, 2024
Merged

added zdf.de #432

merged 14 commits into from
May 5, 2024

Conversation

LethalSnake1337
Copy link
Contributor

No description provided.

@MaxDall
Copy link
Collaborator

MaxDall commented Apr 20, 2024

Hey @LethalSnake1337 thanks for adding this :) looks good 👍 We recently added a new attribute to our unit tests today. Could you merge the latest master branch into your branch and run python -m scripts.generate_parser_test_files -p ZDF once again.

@LethalSnake1337
Copy link
Contributor Author

Hey @LethalSnake1337 thanks for adding this :) looks good 👍 We recently added a new attribute to our unit tests today. Could you merge the latest master branch into your branch and run python -m scripts.generate_parser_test_files -p ZDF once again.

Hey @MaxDall done 👍.

@LethalSnake1337
Copy link
Contributor Author

I added a summary selector and generated a new unit test

@MaxDall MaxDall added the good first PR Good example PR for newcomers label Apr 21, 2024
@addie9800 addie9800 merged commit e4dee1d into flairNLP:master May 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxDall MaxDall MaxDall approved these changes

Assignees
No one assigned
Labels
good first PR Good example PR for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LethalSnake1337 @MaxDall @addie9800