Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Bayerischer Rundfunk as publisher #435

Merged
merged 9 commits into from
May 5, 2024
Merged

Conversation

MK2112
Copy link
Contributor

@MK2112 MK2112 commented Apr 21, 2024

Hey, I added the German "Bayerischer Rundfunk" as publisher. I also generated and ran tests as per the guidelines and added the new publisher to supported_publishers.md.

@MaxDall
Copy link
Collaborator

MaxDall commented Apr 22, 2024

Hey @MK2112, there seems to be something of with your test case. It includes duplicate content as well as headlines with no actual selector set. Could you run python -m scripts.generate_parser_test_files -p BR -oj and push the changes´.

Copy link
Collaborator

@MaxDall MaxDall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding :)

src/fundus/publishers/de/br.py Outdated Show resolved Hide resolved
@MK2112 MK2112 requested a review from MaxDall April 22, 2024 16:52
MaxDall
MaxDall previously approved these changes Apr 27, 2024
@addie9800 addie9800 merged commit 5a5a3d8 into flairNLP:master May 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants