add-publisher-wdr #439
Merged
add-publisher-wdr #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
requested changes
Apr 22, 2024
Co-authored-by: Max Dallabetta <max.dallabetta@googlemail.com>
Co-authored-by: Max Dallabetta <max.dallabetta@googlemail.com>
|
Hey, @jannispoltier could you rerun |
Hi @MaxDall, I pushed the file and on my local machine the tests were now successful |
MaxDall
previously approved these changes
Apr 27, 2024
MaxDall
previously approved these changes
Apr 27, 2024
addie9800
approved these changes
May 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added the WDR (Westdeutscher Rundfunk) to the collection of German publishers and ran all tests and commands as instructed.
There is just one issue I couldn't resolve as for some article summaries the crawler returns a
<p class="stand small">element although I added an XPath to return<p class="einleitung small">and this element did exist in the given file. However, I couldn't come up with a fix for that problem. Maybe you have a suggestion :)