Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add motorsport magazin #456

Merged
merged 13 commits into from
May 6, 2024

Conversation

lsch0lz
Copy link
Contributor

@lsch0lz lsch0lz commented Apr 24, 2024

Hi!
I added the MotorSport Magazin LINK to fundus 🚀

Note: Black reformatted several files, that I didn't intent to touch. Let me know, if thats OK for you

Copy link
Collaborator

@addie9800 addie9800 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for adding the motorsport magazin. Be sure to run black . before your final commit, otherwise the tests won't go through :)

src/fundus/publishers/de/motorsport_magazin.py Outdated Show resolved Hide resolved
src/fundus/publishers/de/motorsport_magazin.py Outdated Show resolved Hide resolved
@lsch0lz
Copy link
Contributor Author

lsch0lz commented Apr 26, 2024

Hi! @addie9800
I added the correct summary and subheadline selectors. Also the class now has a topics() method.

@addie9800
Copy link
Collaborator

Hi! @addie9800
I added the correct summary and subheadline selectors. Also the class now has a topics() method.

Thanks a lot ;) this looks really good. Black seems really weird, when I run black locally it reformats the file back. But I'll just approve the workflow and we'll see if the test go through.

@lsch0lz
Copy link
Contributor Author

lsch0lz commented Apr 26, 2024

Sounds good!

@MaxDall
Copy link
Collaborator

MaxDall commented Apr 27, 2024

@lsch0lz Could you tell me what version of black is installed in your environment?

@addie9800 The tests won't trigger. The last commit on this branch 29c4a5c was auto-committed and due to GitHubs limitations, those won't trigger workflow runs.

@lsch0lz
Copy link
Contributor Author

lsch0lz commented Apr 27, 2024

@MaxDall I have the newest black version (24.4.2) installed. Just checked and black . doesn't reformat any of the code locally

@MaxDall
Copy link
Collaborator

MaxDall commented Apr 28, 2024

@lsch0lz Thanks :) We pinned the Black version for the repository and are currently at 23.1.0. I'm gonna reformat with 23.1.0 and push on your branch. Then this should be good to go 👍

MaxDall
MaxDall previously approved these changes Apr 29, 2024
# Conflicts:
#	src/fundus/publishers/de/__init__.py
@MaxDall MaxDall merged commit cd08875 into flairNLP:master May 6, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants