Add new publisher Vogue #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new file: src/fundus/publishers/de/vogue.py
new file: src/test.py
new file: tests/resources/parser/test_data/de/Vogue_2024_04_28.html.gz modified: tests/resources/parser/test_data/de/meta.info modified: docs/supported_publishers.md modified: src/fundus/publishers/de/__init__.py modified: src/fundus/publishers/de/vogue.py
modified: src/fundus/publishers/de/__init__.py modified: src/fundus/publishers/de/vogue.py
MaxDall
requested changes
Apr 29, 2024
MaxDall
requested changes
Apr 29, 2024
new file: tests/resources/parser/test_data/de/VogueDE.json new file: tests/resources/parser/test_data/de/VogueDE_2024_04_30.html.gz modified: tests/resources/parser/test_data/de/meta.info Changes not staged for commit: modified: docs/supported_publishers.md modified: src/fundus/publishers/de/__init__.py deleted: src/fundus/publishers/de/vogue.py
modified: docs/supported_publishers.md modified: src/fundus/publishers/de/__init__.py renamed: src/fundus/publishers/de/vogue.py -> src/fundus/publishers/de/vogue_de.py
|
Hi Max, I have fixed the problems you mentioned. Please review the code again and see if the PR can be committed. Thanks! @MaxDall |
|
@Oreo7985 I adjusted the selectors. |
MaxDall
previously approved these changes
Apr 30, 2024
# Conflicts: # docs/supported_publishers.md # src/fundus/publishers/de/__init__.py # tests/resources/parser/test_data/de/meta.info
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.