Fix author parsing for BSZ
#518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
previously approved these changes
May 16, 2024
| @@ -85,7 +88,7 @@ def get_value_by_key_path(self, key_path: List[str], default: Any = None) -> Opt | |||
| tmp = nxt | |||
| return tmp | |||
|
|
|||
| def bf_search(self, key: str, depth: Optional[int] = None, default: Any = None) -> Optional[Any]: | |||
| def bf_search(self, key: str, depth: Optional[int] = None, default: Optional[_T] = None) -> Union[Any, _T]: | |||
There was a problem hiding this comment.
Why does it make sense to update the return value to Union[Any, _T]?
There was a problem hiding this comment.
So mypy does know that if a default is given, at least that type is returned.
There was a problem hiding this comment.
Ah ok. I didn't know mypy was able to make that connection. Thanks
addie9800
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the current generic implementation of author parsing for
BSZas well as replacing the current test case with a more challenging one.