Update TechCrunch
#522
Merged
Update TechCrunch
#522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
requested changes
May 17, 2024
|
|
||
| @attribute | ||
| def title(self) -> Optional[str]: | ||
| return self.precomputed.meta.get("og:title") |
There was a problem hiding this comment.
I would parse this from the JSON, since the og:title tag value has an extra | TechCrunch appended to the headline
There was a problem hiding this comment.
Actually the same problem also occurs with V1. Also, since (almost) only the selectors are changed, I think also a minor parser update (V1_1) would be enough to spare all the duplicate code.
There was a problem hiding this comment.
The headline referenced in the LD+JSON suffers from encoding problems. I left it as is and removed | TechCrunch
| @@ -14,10 +14,42 @@ | |||
|
|
|||
|
|
|||
| class TechCrunchParser(ParserProxy): | |||
| class V2(BaseParser): | |||
| _summary_selector: XPath = CSSSelector("div.entry-content > p#speakable-summary") | |||
| _paragraph_selector: XPath = CSSSelector("div.entry-content > p:not(#speakable-summary)") | |||
There was a problem hiding this comment.
Do we want to also parse bulletpoint lists? If so, I have found one usage: https://techcrunch.com/2024/05/15/senate-study-proposes-at-least-32b-yearly-for-ai-programs/
addie9800
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
TechCrunchto adapt the newest layout