Add export feature for Articles #530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@addie9800 Thanks for adding this :) I reworked some parts of the code. Can you give it a quick look and your feedback? |
addie9800
commented
Jun 10, 2024
There was a problem hiding this comment.
This looks really good, thanks for the additions. The only thing I'm wondering is whether or not to include the meta and ld in the saved data by default. That was actually what got me thinking about adding the option of filtering some attributes in the first place, because it's a lot of potentially unnecessary data. What do you think?
|
This looks good, I can't approve it though, since I am the one who opened the PR |
MaxDall
approved these changes
Jun 13, 2024
docs/3_the_article_class.md
Outdated
| @@ -137,4 +138,10 @@ Should print this: | |||
| en | |||
| ``` | |||
|
|
|||
| ## Saving an Article | |||
|
|
|||
| In case you want to save some or all of the articles (refer to the [`save_to_file` parameter](5_advanced_topics.md#saving-the-crawled-articles) in the next section for the latter), the `Article` class provides a `to_json()` function. | |||
There was a problem hiding this comment.
Just a minor thing: Tutorial 5 isn't the next section after this one.
|
Please publish new package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
to_json()function to the Article class and adds the option to save all articles to file.Closes #529