Guard download and streaming of WARC files #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
reviewed
Jun 19, 2024
src/fundus/scraping/crawler.py
Outdated
| scraper = CCNewsScraper(source) | ||
| yield from scraper.scrape(error_handling, extraction_filter, url_filter) | ||
| retries: int = 0 | ||
| while True and retries <= self.retries: |
There was a problem hiding this comment.
Doesn't this simplify to retries <= self.retries?
There was a problem hiding this comment.
That's True slapstick drum sound
addie9800
previously approved these changes
Jun 19, 2024
Slow down WARC path requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR guards the download and streaming of specific WARC files by catching
requests.HTTPErrors andfastwarc.stream_io.StreamErrors and logging the corresponding WARC path aterrorlevel. This is in order to prevent Fundus from crashing when something went wrong during the processing of an individual WARC file.This PR also adds a naive retry mechanic, that tries to reload said WARC file every 30 * current try seconds. By default, it does so three times.