Update EveningStandard parser
#549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addie9800
requested changes
Jul 1, 2024
| class V1_1(V1): | ||
| VALID_UNTIL = datetime.date.today() | ||
| _summary_selector = CSSSelector("div.sc-jgyXzG") | ||
| _subheadline_selector = CSSSelector("div#main div.sc-dFfFtc > h3") |
There was a problem hiding this comment.
It seems like not all articles use this new layout. This article was published today and follows the old layout (which would also miss the subheadlines)
There was a problem hiding this comment.
My guess are that some (but not all) of the lifestyle articles still use the old format for whatever reason:
There was a problem hiding this comment.
Hmm, I would refrain from supporting both layouts. For now, I think it's best to drop support for lifestyle articles.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adjusts the
EveniingStandardparser to the latest version.