Add NationalPost
#584
Merged
Add NationalPost
#584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
requested changes
Aug 26, 2024
Comment on lines
53
to
61
| filter_list = ["Curated", "News", "Newsroom daily", "story", "Canada", "World"] | ||
| filtered_topics = [ | ||
| topic | ||
| for topic in preliminary_topics | ||
| if "NLP Entity Tokens" not in topic | ||
| and "NLP Category" not in topic | ||
| and topic not in filter_list | ||
| and not re.search(r"[0-9a-f]{8}-([0-9a-f]{4}-){3}[0-9a-f]{12}", topic) | ||
| ] |
There was a problem hiding this comment.
Maybe some sort of regex filter would be nice here. Actually, I think you could just use the regular regex_filter.
There was a problem hiding this comment.
I do agree. Using regex_filter seems a bit cursed Typing wise, but it does work just fine.
Comment on lines
2
to
11
| "V1": { | ||
| "authors": [ | ||
| "Special to National Post" | ||
| ], | ||
| "body": { | ||
| "summary": [ | ||
| "A draft policy by the CMA essentially calls for an end to private workplace coverage for virtual health care" | ||
| ], | ||
| "sections": [ | ||
| { |
There was a problem hiding this comment.
I think it would be good to add a test case including at least one subheadline.
Co-authored-by: Max Dallabetta <max.dallabetta@googlemail.com>
MaxDall
previously approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.