Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add The Globe and Mail #587

Merged
merged 4 commits into from
Sep 3, 2024
Merged

Add The Globe and Mail #587

merged 4 commits into from
Sep 3, 2024

Conversation

addie9800
Copy link
Collaborator

No description provided.

@addie9800 addie9800 changed the base branch from master to add-canadian-news-sources August 16, 2024 13:06
Copy link
Collaborator

@MaxDall MaxDall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good 👍

parser=TheGlobeAndMailParser,
sources=[
NewsMap("https://www.theglobeandmail.com/arc/outboundfeeds/news-sitemap-index/?outputType=xml"),
Sitemap("https://www.theglobeandmail.com/arc/outboundfeeds/sitemap-index/?outputType=xml"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this doesn't seem to be a propper Sitemap but just another NewsMap since it only dates back one week.

Comment on lines 11 to 17
"paragraphs": [
"Cannabis firm Canopy Growth WEED-T said on Friday its CEO, David Klein, will retire at the end of the company’s current fiscal year on March 31.",
"Klein was appointed as Canopy Growth’s chairman when the then co-CEO and founder Bruce Linton was fired in 2019.",
"The announcement comes just days after the company reported a smaller-than-expected core loss and pointed to easing doubts around its ability to continue as a going concern.",
"The company had raised doubts about its ability to continue as a going concern last year as it struggled to turn profitable. It later sold its sports nutrition products unit, Biosteel, after seeking bankruptcy protection for it.",
"Canopy Growth said it is in the process of securing a search firm to initiate a comprehensive CEO selection process."
]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to use an article including all selectable content (subheadline, paragraphs) as test case.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll keep that in mind for future publishers as well :)

@addie9800 addie9800 requested a review from MaxDall August 28, 2024 11:28
MaxDall
MaxDall previously approved these changes Sep 3, 2024
Copy link
Collaborator

@MaxDall MaxDall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

Base automatically changed from add-canadian-news-sources to master September 3, 2024 11:16
@addie9800 addie9800 dismissed MaxDall’s stale review September 3, 2024 11:16

The base branch was changed.

# Conflicts:
#	docs/supported_publishers.md
#	src/fundus/publishers/ca/__init__.py
#	tests/resources/parser/test_data/ca/meta.info
@MaxDall MaxDall merged commit 376e7f8 into master Sep 3, 2024
5 checks passed
@MaxDall MaxDall deleted the add-globe-and-mail branch September 3, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants