Custom Robots File Parser #601
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft for now. This would be a possible implementation for a
CustomRobotFileParserinheriting fromRobotFileParserfrom the robotspy package. It looks like a lot, but is mostly copy-pasted from the library codebase. Request-Rate can be implemented analogously. Note that the our code can be reduced by also using the functions from RobotFileParser directly, but that would usually lead to us iterating over objects twice. E.g. in theparse_tokens()function, we could just parse the agents and crawl-delay and then callsuper().parse_tokens()taking care of the rest, but to me that seems like unnecessary double processing.