Fix Sportschau #611
Merged
Fix Sportschau #611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDall
requested changes
Sep 13, 2024
Comment on lines
+17
to
20
| _summary_selector = CSSSelector( | ||
| "p[class='textabsatz columns twelve m-ten m-offset-one l-eight l-offset-two']" " > strong" | ||
| ) | ||
| _paragraph_selector = CSSSelector("article >p.textabsatz:not(p.textabsatz:nth-of-type(1))") |
There was a problem hiding this comment.
I would suggest these two selectors as it seems the summary is always the first paragraph:
_paragraph_selector = XPath("//article/p[position() > 1]")
_summary_selector = XPath("//article/p[1]")There was a problem hiding this comment.
I think that unfortunately that does not always hold, since they also include a wide variety of other sources. E.g. this article from RBB does not include any summary: https://www.sportschau.de/regional/rbb/rbb-fussball-ex-nationalspieler-nico-schulz-spielt-ab-sofort-bei-tuerkischem-zweitligisten-100.html
MaxDall
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The former summary selector was too broad, causing errors when paring articles like this one: https://www.sportschau.de/fussball/nationsleague/ein-wechselspiel-aus-licht-und-schatten,einzelkritik-dfb-102.html . The parsing crashed because the summary nodes are not restricted to the beginning of the article.