Reviewer comments

flame-engine · Sep 23, 2022 · d094f33 · d094f33
1 parent 6e9d5b7
commit d094f33
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/packages/flame_tiled/lib/src/mutable_rect.dart b/packages/flame_tiled/lib/src/mutable_rect.dart
@@ -4,7 +4,7 @@ import 'dart:ui' show Rect;
 class MutableRect extends Rect {
  /// Construct a rectangle from its left, top, right, and bottom edges.
  MutableRect.fromLTRB(this.left, this.top, this.right, this.bottom)
- : super.fromLTRB(left, top, right, bottom); // must call?
+ : super.fromLTRB(left, top, right, bottom);
 
  /// Create a new instance from [other].
  factory MutableRect.fromRect(Rect other) =>

diff --git a/packages/flame_tiled/lib/src/tiled_component.dart b/packages/flame_tiled/lib/src/tiled_component.dart
@@ -140,12 +140,9 @@ class TiledComponent<T extends FlameGame> extends PositionComponent
  );
 
  case MapOrientation.isometric:
- final dimensions = mapWidth + mapHeight;
  final halfTile = tileScaled / 2;
- return Vector2(
- halfTile.x * dimensions,
- halfTile.y * dimensions,
- );
+ final dimensions = mapWidth + mapHeight;
+ return halfTile..scale(dimensions.toDouble());
 
  case MapOrientation.orthogonal:
  return Vector2(