fixes

flame-engine · Oct 24, 2024 · d40e6e3 · d40e6e3
1 parent 2f9fe8d
commit d40e6e3
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 8 deletions.
diff --git a/doc/bridge_packages/flame_console/flame_console.md b/doc/bridge_packages/flame_console/flame_console.md
@@ -61,7 +61,13 @@ Widget build(BuildContext context) {
 
  ```dart
 class MyCustomCommand extends ConsoleCommand<MyGame> {
-  MyCustomCommand() : super('my_command', 'Description of my command');
+  MyCustomCommand();
+
+  @override
+  String get name => 'my_command';
+
+  @override
+  String get description => 'Description of my command';
 
   // The execute method is supposed to return a tuple where the first
   // element is an error message in case of failure, and the second
@@ -82,9 +88,7 @@ ConsoleView(
   onClose: () {
     _game.overlays.remove('console');
   },
-  customCommands: {
-    'custom_cmd': MyCustomCommand(),
-  },
+  customCommands: [MyCustomCommand()],
 ),
 ```
 

diff --git a/packages/flame_console/lib/src/commands/pause_command.dart b/packages/flame_console/lib/src/commands/pause_command.dart
@@ -6,7 +6,10 @@ class PauseConsoleCommand<G extends FlameGame> extends ConsoleCommand<G> {
   @override
   (String?, String) execute(G game, ArgResults results) {
     if (game.paused) {
-      return ('Game is already paused', '');
+      return (
+        'Game is already paused, use the resume command start it again',
+        '',
+      );
     } else {
       game.pauseEngine();
       return (null, '');

diff --git a/packages/flame_console/lib/src/commands/resume_command.dart b/packages/flame_console/lib/src/commands/resume_command.dart
@@ -6,7 +6,7 @@ class ResumeConsoleCommand<G extends FlameGame> extends ConsoleCommand<G> {
   @override
   (String?, String) execute(G game, ArgResults results) {
     if (!game.paused) {
-      return ('Game is not paused', '');
+      return ('Game is not paused, use the pause command to pause it', '');
     } else {
       game.resumeEngine();
       return (null, '');

diff --git a/packages/flame_console/test/src/pause_command_test.dart b/packages/flame_console/test/src/pause_command_test.dart
@@ -27,7 +27,10 @@ void main() {
           final result = command.execute(game, command.parser.parse([]));
           expect(game.paused, isTrue);
 
-          expect(result.$1, 'Game is already paused');
+          expect(
+            result.$1,
+            'Game is already paused, use the resume command start it again',
+          );
         },
       );
     });

diff --git a/packages/flame_console/test/src/resume_command_test.dart b/packages/flame_console/test/src/resume_command_test.dart
@@ -27,7 +27,10 @@ void main() {
           final result = command.execute(game, command.parser.parse([]));
           expect(game.paused, isFalse);
 
-          expect(result.$1, 'Game is not paused');
+          expect(
+            result.$1,
+            'Game is not paused, use the pause command to pause it',
+          );
         },
       );
     });