Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add isometric support for flame_tiled #1885

Merged
merged 3 commits into from
Sep 5, 2022

Conversation

jtmcdole
Copy link
Contributor

@jtmcdole jtmcdole commented Sep 3, 2022

  • Updates some forEach to regular for() loops
  • Adds golden test with license free tilemaps

Description

Adds support for isometric Tiled files.

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have read the [Contributor Guide] and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Do tests count as "examples"?

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #1882

* Updates some forEach to regular for() loops
* Adds golden test with license free tilemaps
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Good job

@jtmcdole
Copy link
Contributor Author

jtmcdole commented Sep 4, 2022

Only those with write access to this repository can merge pull requests.

:)

@spydon
Copy link
Member

spydon commented Sep 4, 2022

Only those with write access to this repository can merge pull requests.

:)

I'm waiting for a second review

@jtmcdole
Copy link
Contributor Author

jtmcdole commented Sep 4, 2022

Ah - solid! I'm looking at hex tiles now... for no other reason than completeness.

@spydon spydon requested a review from a team September 5, 2022 18:51
@spydon spydon merged commit cf82882 into flame-engine:main Sep 5, 2022
@jtmcdole jtmcdole deleted the isometricTiled branch September 6, 2022 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Isometric support in flame_tiled
3 participants