Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests for particles #1966

Closed
spydon opened this issue Sep 29, 2022 · 12 comments · Fixed by #2097
Closed

Unit tests for particles #1966

spydon opened this issue Sep 29, 2022 · 12 comments · Fixed by #2097

Comments

@spydon
Copy link
Member

spydon commented Sep 29, 2022

What could be improved

Currently the particles and the particle system barely has any tests, it would be good to improve the test coverage here.

Why should this be improved

So that we don't accidentally break anything when doing changes.

More information

https://github.com/flame-engine/flame/tree/main/packages/flame/lib/src/particles
https://github.com/flame-engine/flame/tree/main/packages/flame/test/particles

Good to know

Make sure that you comment on the issue that you will be working on this before starting to program.

To set up the Flame environment you need to follow the instructions in our contributing.md doc, if you have any problems setting up your environment (or other issues of course) feel free to ask for help in the Flame channel on our Discord server.

Read through this to see how we organize the tests in flame:
https://docs.flame-engine.org/1.4.0/development/testing_guide.html

@sshiv5768
Copy link

Hey, I want to work on this issue! Please assign me!

@spydon
Copy link
Member Author

spydon commented Oct 1, 2022

Hey, I want to work on this issue! Please assign me!

Super! I've assigned you to the issue, remember to join our Discord server if you have any questions etc. :)

@sshiv5768
Copy link

Thanks @spydon for assigning me this issue.

@ShwetaChauhan18
Copy link
Contributor

@sshiv5768: Let me know if you are not planning to complete this issue. I can start work ASAP.

@ShwetaChauhan18
Copy link
Contributor

@spydon: Let me know if you have unit test, widget test task.

@spydon
Copy link
Member Author

spydon commented Oct 4, 2022

@spydon: Let me know if you have unit test, widget test task.

I'll create a task for you, you have done great work so far! :)

@depimomo
Copy link

depimomo commented Oct 6, 2022

Hi @spydon ! I'm also interested if you have any unit test task, please let me know if you need more help 😆

@spydon
Copy link
Member Author

spydon commented Oct 6, 2022

Hi @spydon ! I'm also interested if you have any unit test task, please let me know if you need more help 😆

Hi, glad that you are interested in helping. 😄
You can write on the unit tests for flame_forge2d issue if you are interested in that one and I'll assign it to you:
#2031

@ShwetaChauhan18
Copy link
Contributor

@spydon: If no one is working on this, I can work.

@spydon
Copy link
Member Author

spydon commented Oct 13, 2022

Any progress here @sshiv5768? Otherwise I'll assign this to @ShwetaChauhan18.

@ShwetaChauhan18
Copy link
Contributor

@sshiv5768 , @spydon: Can I start this?

@spydon spydon assigned ShwetaChauhan18 and unassigned sshiv5768 Oct 17, 2022
@spydon
Copy link
Member Author

spydon commented Oct 17, 2022

@sshiv5768 , @spydon: Can I start this?

Since we've had no reply I've assigned it to you.

ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 18, 2022
  -  unit test for `Particles`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 18, 2022
  -  unit test for `Particles`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 19, 2022
  -  unit test for `Particles`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 19, 2022
  -  unit test for `Particles`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 19, 2022
  -  unit test for `Particles`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 19, 2022
  -  unit test for `Particles`
ShwetaChauhan18 pushed a commit to ShwetaChauhan18/flame that referenced this issue Oct 20, 2022
  -  unit test for `Particles`
spydon pushed a commit that referenced this issue Oct 20, 2022
fix: 🐛 Unit tests for particles #1966: Unit test for Particles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants