-
-
Notifications
You must be signed in to change notification settings - Fork 899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests for particles #1966
Comments
Hey, I want to work on this issue! Please assign me! |
Super! I've assigned you to the issue, remember to join our Discord server if you have any questions etc. :) |
Thanks @spydon for assigning me this issue. |
@sshiv5768: Let me know if you are not planning to complete this issue. I can start work ASAP. |
@spydon: Let me know if you have unit test, widget test task. |
I'll create a task for you, you have done great work so far! :) |
Hi @spydon ! I'm also interested if you have any unit test task, please let me know if you need more help 😆 |
@spydon: If no one is working on this, I can work. |
Any progress here @sshiv5768? Otherwise I'll assign this to @ShwetaChauhan18. |
@sshiv5768 , @spydon: Can I start this? |
Since we've had no reply I've assigned it to you. |
- unit test for `Particles`
- unit test for `Particles`
- unit test for `Particles`
- unit test for `Particles`
- unit test for `Particles`
- unit test for `Particles`
- unit test for `Particles`
What could be improved
Currently the particles and the particle system barely has any tests, it would be good to improve the test coverage here.
Why should this be improved
So that we don't accidentally break anything when doing changes.
More information
https://github.com/flame-engine/flame/tree/main/packages/flame/lib/src/particles
https://github.com/flame-engine/flame/tree/main/packages/flame/test/particles
Good to know
Make sure that you comment on the issue that you will be working on this before starting to program.
To set up the Flame environment you need to follow the instructions in our contributing.md doc, if you have any problems setting up your environment (or other issues of course) feel free to ask for help in the Flame channel on our Discord server.
Read through this to see how we organize the tests in flame:
https://docs.flame-engine.org/1.4.0/development/testing_guide.html
The text was updated successfully, but these errors were encountered: