feat: Add missing parameters to InlineTextStyle #3146
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add missing parameters to
InlineTextStyle
, such asheight
andshadows
.Without this, it is not possible to configure such parameters in the new text rendering pipeline. Since the other parameters are 1:1 to Flutter's
TextStyle
, these missing fields seem to have been just an oversight.However, it does make me question why are we copying the values from Flutter's class. I don't see why we could not just replace all these fields with a single
TextStyle
field. In fact, we could just makeTextPaint
extendFlameTextStyle
and get rid ofInlineTextStyle
altogether. Either way, these can be followups.Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?