Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add missing parameters to InlineTextStyle #3146

Merged
merged 1 commit into from
May 5, 2024

Conversation

luanpotter
Copy link
Member

Description

Add missing parameters to InlineTextStyle, such as height and shadows.

Without this, it is not possible to configure such parameters in the new text rendering pipeline. Since the other parameters are 1:1 to Flutter's TextStyle, these missing fields seem to have been just an oversight.

However, it does make me question why are we copying the values from Flutter's class. I don't see why we could not just replace all these fields with a single TextStyle field. In fact, we could just make TextPaint extend FlameTextStyle and get rid of InlineTextStyle altogether. Either way, these can be followups.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@luanpotter luanpotter marked this pull request as ready for review May 5, 2024 10:25
@luanpotter luanpotter merged commit ce9392a into main May 5, 2024
8 checks passed
@luanpotter luanpotter deleted the luan.in-text-style-plus branch May 5, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants