fix: Disallow mutatation of SpriteAnimationGroupComponent.animations
#3183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
1 task
erickzanardo
approved these changes
Jun 5, 2024
|
Is it the same way in the SpriteGroupComponent? |
I thought it didn't, but it does! |
|
@erickzanardo this is the follow-up to fix it for |
Cool, I am both right and late hahahha |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Many users try to modify the
SpriteAnimationGroupComponent.animationsmap, but that doesn't work since it has to go through the setter, so this PR makes the returned map from the getter unmodifiable.Checklist
docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues