Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disallow mutatation of SpriteGroupComponent.sprites #3185

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Jun 5, 2024

Description

Many users try to modify the SpriteGroupComponent.sprites map, but that doesn't work since it has to go through the setter, so this PR makes the returned map from the getter unmodifiable.
You can either set it by using the setter or set a particular sprite by using the newly created updateSprite method.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon merged commit 7c40034 into main Jun 5, 2024
8 checks passed
@spydon spydon deleted the fix/disallow-mutate-sprites-map branch June 5, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants