Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update version of lints to comply with new pub requirements #3223

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

luanpotter
Copy link
Member

Description

Update version of lints to comply with new pub requirements.

Turns out we are losing significant pub points due to lint violations:

image

The root cause was our severely outdated version of core lints used on flame_lint.
This updates it and fixes the new rule which forbids accessing parameters that are wildcards.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad!

@spydon spydon changed the title chore: Update version of lints to comply with new pub requirements fix: Update version of lints to comply with new pub requirements Jul 16, 2024
@spydon spydon merged commit 1b0bee7 into main Jul 16, 2024
9 checks passed
@spydon spydon deleted the luan.lint.4 branch July 16, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants