Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update version of lints to comply with new pub requirements #3223

Merged
merged 1 commit into from
Jul 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions examples/lib/stories/components/time_scale_example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -108,11 +108,14 @@ class _Chopper extends SpriteAnimationComponent
}

@override
void onCollisionStart(Set<Vector2> _, PositionComponent other) {
void onCollisionStart(
Set<Vector2> intersectionPoints,
PositionComponent other,
) {
if (other is _Chopper) {
game.timeScale = 0.25;
}
super.onCollisionStart(_, other);
super.onCollisionStart(intersectionPoints, other);
}

@override
Expand Down
18 changes: 12 additions & 6 deletions examples/lib/stories/system/step_engine_example.dart
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,10 @@ class StepEngineExample extends FlameGame
}

@override
KeyEventResult onKeyEvent(_, Set<LogicalKeyboardKey> keysPressed) {
KeyEventResult onKeyEvent(
KeyEvent event,
Set<LogicalKeyboardKey> keysPressed,
) {
if (keysPressed.contains(LogicalKeyboardKey.keyP)) {
paused = !paused;
} else if (keysPressed.contains(LogicalKeyboardKey.keyS)) {
Expand All @@ -71,7 +74,7 @@ class StepEngineExample extends FlameGame
_stepTimeMultiplier -= 1;
_controlsText.text = _text;
}
return super.onKeyEvent(_, keysPressed);
return super.onKeyEvent(event, keysPressed);
}

// Creates the circle detectors.
Expand Down Expand Up @@ -128,14 +131,17 @@ class _DetectorComponents extends CircleComponent with CollisionCallbacks {
});

@override
void onCollisionStart(_, __) {
void onCollisionStart(
Set<Vector2> intersectionPoints,
PositionComponent other,
) {
paint.color = BasicPalette.black.color;
super.onCollisionStart(_, __);
super.onCollisionStart(intersectionPoints, other);
}

@override
void onCollisionEnd(__) {
void onCollisionEnd(PositionComponent other) {
paint.color = BasicPalette.white.color;
super.onCollisionEnd(__);
super.onCollisionEnd(other);
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -119,15 +119,15 @@ class JoystickComponent extends PositionComponent
}

@override
bool onDragEnd(_) {
super.onDragEnd(_);
bool onDragEnd(DragEndEvent event) {
super.onDragEnd(event);
onDragStop();
return false;
}

@override
bool onDragCancel(_) {
super.onDragCancel(_);
bool onDragCancel(DragCancelEvent event) {
super.onDragCancel(event);
onDragStop();
return false;
}
Expand Down
1 change: 0 additions & 1 deletion packages/flame_behavior_tree/behavior_tree/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,5 @@ dependencies:

dev_dependencies:
flame_lint: ^1.2.0
lints: ^3.0.0
mocktail: ^1.0.3
test: any
2 changes: 1 addition & 1 deletion packages/flame_lint/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ environment:
sdk: ">=3.4.0 <4.0.0"

dependencies:
lints: ^3.0.0
lints: ^4.0.0

dev_dependencies:
dartdoc: ^8.0.8
Loading