fix: Allow most basic and advanced gesture detectors together #1208
Conversation
spydon
requested review from
erickzanardo,
luanpotter,
wolfenrain and
renancaraujo
| void onTapUp(int id, TapUpInfo info) { | ||
| super.onTapUp(id, info); | ||
| final touchPoint = info.eventPosition.game; | ||
| final handled = children.any((c) => c.shouldRemove); |
There was a problem hiding this comment.
I put a TODO on the onTap* that it should return whether any child handled the tap (returned false)
| } | ||
|
|
||
| @override | ||
| void onDoubleTap() { |
There was a problem hiding this comment.
this seems like a very specific feature to showcase on this example
There was a problem hiding this comment.
It was here already, I just moved the class.
There was a problem hiding this comment.
I know, but we can always improve :P
| WARNING: Both Advanced and Basic detectors detected. | ||
| Advanced detectors will override basic detectors and the later will not receive events | ||
| ''', | ||
| !(game is MultiTouchDragDetector && |
There was a problem hiding this comment.
Can we have some tests for these new assertions?
|
|
||
| @override | ||
| Future<void> onLoad() async { | ||
| await super.onLoad(); |
There was a problem hiding this comment.
why do you need this, if super's onLoad is empty?
There was a problem hiding this comment.
It was already there, I just moved the class.
But I can remove it.
There was a problem hiding this comment.
Ah right, it has @mustCallSuper on it.
There was a problem hiding this comment.
well, the question then why must it, if the super doesn't do anything?
There was a problem hiding this comment.
I don't remember, there was some reasoning behind it though. Do you remember @erickzanardo or @luanpotter?
There was a problem hiding this comment.
The reason is some FlameGame and Component mixins do initialization onLoad. so if people don't call super, those are missed, causing bugs. Thus we added the annoation so people would not make such mistake.
Description
Most gesture detectors work together now, except for the
PanDetectororScaleDetectortogether with theMultiTouchDragDetector. Maybe even theScaleDetectorwill work with theMultiTouchDragDetector, will have to try.Also simplified the example game a little bit.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///) and updated/added examples indoc/examples.flutter formatand theflutter analyzedoes not report any problems.[next]inCHANGELOG.md.Draftstatus, by clicking on theReady for reviewbutton in this PR.Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?
CHANGELOG.md).Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR.