fix: flame svg perfomance #1373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erickzanardo
requested review from
spydon,
luanpotter,
renancaraujo and
wolfenrain
st-pasha
reviewed
Feb 15, 2022
erickzanardo
force-pushed
the
erick.svg-perfomance
branch
from
f422b67
to
fd7f2a3
Compare
spydon
approved these changes
Feb 18, 2022
st-pasha
reviewed
Feb 18, 2022
st-pasha
pushed a commit
to st-pasha/flame
that referenced
this pull request
Feb 21, 2022
* fix: flame svg perfomance * PR suggestions and some tests * linting * addressing comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes Flame SVG perfomance by caching it in an image.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the
relevant checkboxes (
[x]). This will ensure a smooth and quick review process.fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Does your PR require Flame users to manually update their apps to accommodate your change?
!,e.g.
feat!:,fix!:).Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database.
Indicate which of these issues are resolved or fixed by this PR, i.e. Fixes #xxxx