Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Scale (zoom) effects can now be applied to Viewfinder in CameraComponent #1514

Merged
merged 5 commits into from
Apr 9, 2022
Merged

feat: Scale (zoom) effects can now be applied to Viewfinder in CameraComponent #1514

merged 5 commits into from
Apr 9, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Apr 5, 2022

Description

  • Added ScaleProvider interface
  • The interface is implemented by PositionComponent and by Viewfinder
  • ScaleEffect is applicable to any target that implements ScaleProvider

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

spydon
spydon approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@spydon spydon enabled auto-merge (squash) April 9, 2022 00:29
@spydon spydon merged commit 403b6e6 into flame-engine:main Apr 9, 2022
@st-pasha st-pasha deleted the ps/scale-provider branch April 9, 2022 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

@wolfenrain wolfenrain Awaiting requested review from wolfenrain

@luanpotter luanpotter Awaiting requested review from luanpotter

@renancaraujo renancaraujo Awaiting requested review from renancaraujo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@st-pasha @spydon @erickzanardo