Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Camera's Viewfinder can now be affected by rotation effects #1527

Merged
merged 4 commits into from
Apr 9, 2022
Merged

feat: Camera's Viewfinder can now be affected by rotation effects #1527

merged 4 commits into from
Apr 9, 2022

Conversation

st-pasha
Copy link
Contributor

@st-pasha st-pasha commented Apr 9, 2022

Description

  • Added interface AngleProvider, which is currently implemented by PositionComponent and Viewfinder;
  • The RotateEffects are now targeting any component with an AngleProvider.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

spydon
spydon approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, since this is the same thing as the other two I think we can merge this directly.

@spydon spydon enabled auto-merge (squash) April 9, 2022 23:43
@spydon spydon merged commit f46cae0 into flame-engine:main Apr 9, 2022
@st-pasha st-pasha deleted the ps/angle-provider branch April 9, 2022 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@st-pasha @spydon