fix: Possibility to create RenderableTiledMap from TiledMap

[Hwan-seok]

Description

Fixes #1533

Checklist

• The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
• I have read the Contributor Guide and followed the process outlined for submitting PRs.
• I have updated/added tests for ALL new/updated/fixed functionality.
• I have updated/added relevant documentation in docs and added dartdoc comments with ///.
• I have updated/added relevant examples in examples.

Breaking Change

• Yes, this is a breaking change.
• No, this is not a breaking change.

Related Issues

[st-pasha]

Isn't it a bit inconsistent that loadMap() returns a TiledMap, while fromMap() returns a RenderableTileMap?

[spydon]

Isn't it a bit inconsistent that loadMap() returns a TiledMap, while fromMap() returns a RenderableTileMap?

Good catch, maybe fromMap should be renamed to fromTiledMap, since this is in the RenderableTileMap class I think it makes sense that it returns that type. And maybe loadMap should actually be living in the TiledMap class?

[spydon]

Created: flame-engine/tiled.dart#42
This PR should be able to use that one instead of loadMap.

It should use the tiled method instead

[spydon]

@Hwan-seok If you do a pub upgrade now tiled.dart should expose TiledMap.fromString that you can use instead of loadMap. You have to send in FlameTsxProvider.parse to the method as the second argument.

[Hwan-seok]

@spydon
I got it, I will fix the PR.

[spydon]

@spydon
I got it, I will fix the PR.

Super, looks great! I'll do a release of this tonight. :)

[Hwan-seok]

@spydon
Great!

By the way, Is the release includes the main package of flame? because it is not compatible with flame: ^1.1.0 because of #1522 but this has dependencies on it.

[spydon]

@spydon Great!

By the way, Is the release includes the main package of flame? because it is not compatible with flame: ^1.1.0 because of #1522 but this has dependencies on it.

Yup, melos calculates which packages that needs to be released, so at least Flame 1.1.1, flame_forge2d and flame_test will also be released.

[wolfenrain]

LGTM