Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Bump forg2d version and have flame_forge2d examples use latest syntax #1535

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

spydon
Copy link
Member

@spydon spydon commented Apr 11, 2022

Description

This is a preparation for the Forge2D release.
I will later move in these examples to the main examples directory.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

@spydon spydon changed the title fix: Update flame_forge2d examples to use latest Forge2D syntax feat: Bump forg2d version and have flame_forge2d examples use latest syntax Apr 11, 2022
Copy link
Contributor

@wolfenrain wolfenrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Much more readable imho. The analyze did fail tho ;-)

@spydon
Copy link
Member Author

spydon commented Apr 12, 2022

LGTM! Much more readable imho. The analyze did fail tho ;-)

#1533 has to be merged first, so review that one too ;)

@spydon spydon merged commit 4f7a12e into main Apr 12, 2022
@spydon spydon deleted the spydon.update-forge2d-examples branch April 12, 2022 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants