Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ParentIsA missing mustCallSuper #1604

Merged
merged 1 commit into from
May 4, 2022
Merged

fix: ParentIsA missing mustCallSuper #1604

merged 1 commit into from
May 4, 2022

Conversation

wolfenrain
Copy link
Contributor

@wolfenrain wolfenrain commented May 4, 2022 •
edited
Loading

Description

In #1566 the mustCallSuper was forgotten after the refactor back to the original solution.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

@wolfenrain wolfenrain merged commit 7212901 into main May 4, 2022
@wolfenrain wolfenrain deleted the fix/parent-is-a-missing-must-call-super branch May 4, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wolfenrain @spydon