feat: World bounds for a CameraComponent #1605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
requested review from
spydon,
erickzanardo,
luanpotter,
renancaraujo and
wolfenrain
spydon
approved these changes
May 7, 2022
alestiago
reviewed
May 8, 2022
Comment on lines
+58
to
+61
| assert( | ||
| parent is PositionProvider, | ||
| 'Can only apply this behavior to a PositionProvider', | ||
| ); |
There was a problem hiding this comment.
Should we use the ParentIsA mixin?
There was a problem hiding this comment.
The requirement that parent must be a PositionProvider only applies in case when _target == null. If, on the other hand, target was specified explicitly in the constructor, then the parent can be any.
luanpotter
approved these changes
May 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BoundedPositionBehaviorwhich could restrict the movement of another component.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues
Closes #812