Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Remove unecessary copy operation on Camera #1708

Merged
merged 2 commits into from
Jun 7, 2022
Merged

refactor: Remove unecessary copy operation on Camera #1708

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6184db5
refactor: Remove unecessary copy operation on Camera
luanpotter Jun 7, 2022
b3d12f9
Merge branch 'main' into luan.camera-fix
spydon Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/flame/lib/src/game/camera/camera.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ class Camera extends Projector {
/// When using this method you are responsible for saving/restoring canvas
/// state to avoid leakage.
void apply(Canvas canvas) {
canvas.transform(_transformMatrix(position, zoom).storage);
canvas.transform(_transformMatrix().storage);
}

Vector2? _canvasSize;
Expand All @@ -178,7 +178,7 @@ class Camera extends Projector {
_viewport.resize(canvasSize);
}

Matrix4 _transformMatrix(Vector2 position, double zoom) {
Matrix4 _transformMatrix() {
final translateX = -_position.x * zoom;
final translateY = -_position.y * zoom;
if (_transform.m11 == zoom &&
Expand Down