Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct flutter constraint #1731

Merged
merged 4 commits into from
Jun 14, 2022
Merged

Conversation

spydon
Copy link
Member

@spydon spydon commented Jun 14, 2022

Description

Pub gives a warning when using ^3.0.0 since that also implies less than 4.0.0, which your Flutter dependency shouldn't be.
With >= it is an open range instead.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • No, this is not a breaking change.

Related Issues

@spydon spydon enabled auto-merge (squash) June 14, 2022 18:19
@spydon spydon disabled auto-merge June 14, 2022 18:19
@spydon spydon requested a review from a team June 14, 2022 18:19
@spydon spydon enabled auto-merge (squash) June 14, 2022 18:27
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit c738384 into main Jun 14, 2022
@spydon spydon deleted the spydon/correct-flutter-constraint branch June 14, 2022 23:59
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jun 18, 2022
Pub gives a warning when using ^3.0.0 since that also implies less than 4.0.0, which your Flutter dependency shouldn't be.
With >= it is an open range instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants