feat: Adding ClipComponent #1769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spydon
approved these changes
Jul 1, 2022
|
Related issue: #1274 |
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
st-pasha
reviewed
Jul 1, 2022
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
spydon
reviewed
Jul 1, 2022
st-pasha
reviewed
Jul 1, 2022
alestiago
reviewed
Jul 16, 2022
7 tasks
st-pasha
reviewed
Jul 20, 2022
There was a problem hiding this comment.
I like the idea and the implemmentation looks good.
The only thing is that it is hard to trigger a path reconstruction if after load/mount, the user requires to change the shape of the clipped area (eg: update the size of the clipped rectangle given a game constraint)
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
erickzanardo
requested review from
st-pasha,
alestiago and
renancaraujo
and removed request for
alestiago
spydon
approved these changes
Sep 5, 2022
Co-authored-by: Lukas Klingsbo <me@lukas.fyi>
spydon
approved these changes
Sep 6, 2022
st-pasha
reviewed
Sep 7, 2022
|
|
||
| Shape _buildShape(); | ||
|
|
||
| void _prepare() { |
There was a problem hiding this comment.
This could be public, allowing the shape to be modified by an external force (such as an effect or a tap callback).
alestiago
reviewed
Sep 7, 2022
wolfenrain
approved these changes
Sep 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a new component called
ClipComponentthat clips the canvas area based on its size and shape.Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examples.Breaking Change
Related Issues