Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace images in README with absolute path #1796

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

immadisairaj
Copy link
Contributor

The images path under sponsors has a relative path from the repository, which are being changed to absolute path (starting with https)

Description

There are no breaking changes for this PR. The only changes are the image path changes in README (and translations) which now point to the images actual path in web

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

The other 3 checks are not required.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Fixes #1795

The images path under sponsors has a relative path from the repository,
which are being changed to absolute path (starting with https)
@spydon spydon merged commit e53b633 into flame-engine:main Jul 12, 2022
@immadisairaj immadisairaj deleted the readme-images branch July 12, 2022 11:46
st-pasha pushed a commit to st-pasha/flame that referenced this pull request Jul 13, 2022
The images path under sponsors has a relative path from the repository, which are being changed to absolute path (starting with https)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make images in README point to absolute path instead of relative path
3 participants