Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added ability to control overlays via the RouterComponent #1840

Merged
merged 14 commits into from
Aug 19, 2022

Conversation

st-pasha
Copy link
Contributor

Description

  1. Class _ActiveOverlays renamed into OverlayManager and move into its own file. The class is still marked as internal.
  2. In GameWidget.controlled constructor the properties initialActiveOverlays and mouseCursor were missing, now added.
  3. Created class OverlayRoute for encapsulating an overlay-handling logic within the RouterComponent.
  4. New overlay builders can now be added to the game at runtime.
  5. The OverlaysManager._activeOverlays property is now a list instead of a set, so that the overlays would be displayed in the specific order requested by the user.

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • [-] I have updated/added relevant examples in examples.

Breaking Change

  • [-] Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Closes #1762

Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

doc/flame/router.md Outdated Show resolved Hide resolved
@spydon spydon enabled auto-merge (squash) August 19, 2022 16:55
@spydon spydon merged commit e2de70c into main Aug 19, 2022
@spydon spydon deleted the ps.navigator-overlays branch August 19, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow overlays to be added/removed via the Navigator
3 participants