perf: SpriteAnimationWidget will re-render only when needed #1876
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As-Is
SpriteAnimationWidget
is re-rendering even if the frame index is not changed. This wastes the resource.To-Be
SpriteAnimationWidget
now only re-renders(call setState) only when the frame index is changed.Additionally, the
canvas.renderRotated
is called inSpritePainter
even though the rotation angle is 0. I think it is not needed.Checklist
fix:
,feat:
,docs:
etc).docs
and added dartdoc comments with///
.examples
.Breaking Change