Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Bridge package docs: flame_fire_atlas #2077

Merged
merged 31 commits into from
Oct 21, 2022

Conversation

dipakp2726
Copy link
Contributor

Description

Added bridging docs for flame_fire_atlas

Checklist

  • The title of my PR starts with a [Conventional Commit] prefix (fix:, feat:, docs: etc).
  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Closes #1962 Bridge package docs: flame_fire_atlas

@dipakp2726
Copy link
Contributor Author

Example Video

Screen.Recording.2022-10-14.at.5.10.38.PM.mov

doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
@dipakp2726 dipakp2726 requested review from spydon and removed request for erickzanardo October 16, 2022 04:26
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
dipakp2726 and others added 7 commits October 16, 2022 21:19
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
@spydon spydon requested review from erickzanardo and a team October 16, 2022 16:47
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@dipakp2726 dipakp2726 requested review from st-pasha and removed request for erickzanardo October 17, 2022 10:37
 the "installation" section shouldn't be up front:it's like trying to convince someone to buy a product without them seeing it first.

## Texture atlas

A texture atlas is an image that contains data from several smaller images that have been packed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably expand this section a little bit and put more light and maybe an example.

Also a link to a wiki about texture atlases could add a good value to this section.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you suggest me some examples if possible,
i did quite good search but i couldn't find that can explain in simple/plain words

added texture atlas wiki link
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
dipakp2726 and others added 3 commits October 18, 2022 07:52
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Show resolved Hide resolved
dipakp2726 and others added 4 commits October 18, 2022 21:17
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line lengths have to be corrected in the suggestions that I have left.

doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
doc/flame_fire_atlas/fire_atlas.md Outdated Show resolved Hide resolved
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once the remaining comments are addressed.

dipakp2726 and others added 7 commits October 21, 2022 08:01
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
Co-authored-by: Lukas Klingsbo <lukas.klingsbo@gmail.com>
@spydon spydon enabled auto-merge (squash) October 21, 2022 12:20
@spydon spydon merged commit 8395126 into flame-engine:main Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bridge package docs: flame_fire_atlas
4 participants