Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SpeedController advance() should execute after its effect's onStart() #2173

Merged
merged 3 commits into from
Nov 22, 2022
Merged

fix: SpeedController advance() should execute after its effect's onStart() #2173

merged 3 commits into from
Nov 22, 2022

Conversation

pgirald
Copy link
Contributor

@pgirald pgirald commented Nov 19, 2022

…rt()

Description

SpeedEffectController always completes inmediatly when it is inside a SequenceEffect. That happens because SpeedEffectController's advance() method executes before it's MeasurableEffect's onStart() method, that is, before it's parent effect is initialized (see #2096).

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

Fixes #2096

spydon
spydon approved these changes Nov 19, 2022
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! It would be very nice with a test that verifies this behavior, so that we don't get a regression at a later stage.

@st-pasha st-pasha changed the title fix: SpeedController advance() should execute after it's effect onSta… fix: SpeedController advance() should execute after its effect's onStart() Nov 19, 2022
luanpotter
luanpotter approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erickzanardo
erickzanardo approved these changes Nov 22, 2022
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once we get a test for the new behaviour

@spydon spydon enabled auto-merge (squash) November 22, 2022 21:53
@spydon spydon merged commit 7a1e2e8 into flame-engine:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

@erickzanardo erickzanardo erickzanardo approved these changes

@luanpotter luanpotter luanpotter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MoveToEffect, RemoveEffect and SpeedEffectController not working inside SequenceEffect
4 participants
@pgirald @spydon @erickzanardo @luanpotter