fix: Jenny now always stringifies whole numbers without .0 #2265
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The YarnSpinner language supports variables of type
numeric
, but not integers or doubles. The closest concept in Dart is thenum
type, which is a union ofint
anddouble
. However, we need to make sure that a number stringifies in a consistent manner regardless of whether its underlying representation is integer or double. Thus, we must make sure that12
and12.0
not only compare equal (which they already do), but also have the same representation when converted to string.This PR ensures that any integer-like double looks like an integer when converted to a string.
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?